Resolve more changed after checked errors #31208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
adolgachev and
mmalerba
and removed request for
a team
crisbeto
added
the
merge: preserve commits
crisbeto
force-pushed
the
final-exhaustive-checks
branch
from
ba80e46 to
3b74398
Compare
andrewseguin
approved these changes
May 23, 2025
Turns the `_activeIndex` of the key manager into a signal internally to help resolve "changed after checked" errors in some components.
Resolves a "changed after checked" error in the list due to the disabled state of the item being dependent on the state of the list.
Removes the opt out of exhaustive checks from the menu tests. The issue was only in one test that wasn't set up correctly.
Resolves several "changed after checked" errors in the stepper by converting internal state to signals.
crisbeto
force-pushed
the
final-exhaustive-checks
branch
from
3b74398 to
3fa15de
Compare
Updates more internal state of the CDK stepper to be signal-based in order to avoid inconsistencies.
|
The changes were merged into the following branches: main, 20.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the remaining "changed after checked" errors that were masked by exhaustive checks being turned off in tests.